Skip to content

napi: implement uv_idle_t, uv_prepare_t, uv_check_t and uv_timer_t on posix - #39892

Closed
robobun wants to merge 3 commits into
farm/72abd354/uv-async-work-posixfrom
farm/72abd354/uv-loop-watchers-timers
Closed

robobun wants to merge 3 commits into
farm/72abd354/uv-async-work-posixfrom
farm/72abd354/uv-loop-watchers-timers

Conversation

@robobun

@robobun robobun commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #39652, its base branch: review the last commit only.

Problem

Fix

  • uv_idle_t, uv_prepare_t and uv_check_t are one struct, UvWatcher. auto_tick (jsc_hooks.rs) runs idle and prepare handles before its poll and check handles after it. A started idle handle makes the poll non-blocking, as in libuv.
  • uv_timer_t is an EventLoopTimer in the VM's timer heap. It does not fit in the handle, so uv_timer_init allocates a UvTimerNode and uv_close frees it. As in libuv, a due timer is stopped, re-armed if it repeats, then called back.
  • RefState replaces each handle's KeepAlive: a handle keeps the process alive while it is started and ref'd. The uv_handle_t functions accept all five types. 18 stubs go away.
  • Verified: test/napi/uv.test.ts, 15 new tests, all fail on the stock bun. Other suites in Notes.

Background

Notes

Sentry, 90 days: about 60 events name uv_check_init and 44 uv_timer_init, after about 500 for uv_default_loop and 190 for uv_async_init. Issues on the public 1.4.0 release, all macOS arm64 addons: BUN-4P00 (uv_timer_init from an addon constructor called by a JS timer, the shape uv.test.ts now covers) and BUN-4Q9K (uv_idle_init during process.dlopen).

Layout. The addon allocates each handle, so Bun's state has to fit in libuv's sizeof: uv_idle_t, uv_prepare_t and uv_check_t are 120 bytes with the callback at offset 96, uv_timer_t is 152 bytes, both asserted at compile time. uv_now and uv_update_time come with the timers.

Semantics kept from libuv: uv_*_start of a started or closing watcher returns 0 and changes nothing; a missing callback is UV_EINVAL; uv_timer_start of a closing timer is UV_EINVAL, of a started one a restart; uv_timer_again is UV_EINVAL for a timer never started and a no-op for one with no repeat; uv_timer_set_repeat takes effect at the next fire or uv_timer_again; inside its callback a one-shot timer reads as stopped and a repeating one as started; uv_has_ref keeps reporting the flag after uv_close (#39652 reported 0 there); a handle passed to the functions of another type gets UV_EINVAL, where libuv asserts. Differences: the watchers of one kind run in start order (libuv's queue happens to run them in reverse start order); uv_timer_get_due_in is 0 for a stopped timer (libuv reports the stale deadline); uv_now reads the clock the timer heap uses instead of a per-iteration cache.

The walk over a watcher list moves each handle back into the live list before its callback, the way #39652 dispatches async handles, so a stop or close from any callback finds it. A nested loop run from a callback finds in_walk set and skips the inner walk. before_poll and after_poll are in both auto_tick (waits, module loading) and auto_tick_active (the main run loop, Workers). Once the VM stops running script they do nothing, like the async dispatch; a terminated Worker's loop is woken and exits on its terminate flag.

The timer node is freed in uv_close, not in the close task: every function that reads the node checks active or the closing flag first (the closed-timer test calls each of them after uv_close, under ASAN in CI), and a VM that is shutting down can refuse the task. The VM's teardown unlinks every timer without telling its owner (disarm_all_for_vm_teardown), so stop reads the node's own state before it removes it.

Cost on the tick path when no addon uses these: three Vec::is_empty reads per tick. A reduced setInterval-leak-fixture.js (15 batches of 10,000 callbacks) on this debug build: 12.3 to 14.4 s on the base commit, 12.4 to 13.5 s with this change. The full fixture takes over five minutes on this debug build either way (4 s on the release bun), so the leak tests in test/js/web/timers time out here with and without this change; the other 45 tests in those four files pass.

Tests. The prepare/check test does socket I/O: the data callback runs inside the poll, so its io line has to land between prepare N and check N of one iteration (iteration 2 here), and the check callback of that iteration closes both handles from inside the walk. In the idle test the idle handle is the only thing turning the loop, so an idle handle that let the poll block would hang the child. The unref'd timer and the closed timer are one-hour timers: the child exiting is the assertion. The Worker tests check that watchers and timers land on the Worker's own loop and timer heap and let it exit. Two tests throw from every callback and check that the process still reaches the close that lets it exit, with exit code 1. The error test grew from 3 to 14 cases.

@sentry/profiling-node also needs uv_cpu_info, uv_free_cpu_info and V8 APIs, which are not in this change.

Suites run: test/napi/uv.test.ts (five runs, 37 pass each), test/napi/uv_stub.test.ts, test/js/web/timers/{setTimeout,setInterval,setImmediate}.test.js and timer-heap-race.test.ts, cargo clippy -p bun_runtime -p bun_event_loop, bun scripts/rust-check-all.ts (12 targets), cargo fmt --check, clang-format:check, prettier.


no test proof · iteration 6 · platform-specific test(s) that do not run on this machine, deferring to CI, which covers all platforms: test/napi/uv.test.ts

@robobun

robobun commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status: ready for review, rebased with its base onto main (now 0697fc5 on top of #39652's 1b93209; 38 pass locally). It lands after #39652 (the base branch). Once #39652 is in main, this branch gets rebased onto main so that the PR is this one commit against main.

CI on the current head, 38b2216 (https://buildkite.com/bun/bun/builds/103866): 177 of 179 jobs passed, and the uv tests passed on every Linux and macOS lane. The two red jobs are the Windows 2019 x64 test shards, with two tests this change does not touch (it is posix only): bake/deinitialization.test.ts (a segfault that predates both PRs) and bun-server.test.ts (a GC count that fails on main too). Both are reported to main-break triage. The earlier run on db988c0 (build 102423) had the same shape: 177 of 179, with fetch-abort-slow-connect.test.ts red on one macOS machine instead of the bake test. No retrigger was pushed: the Windows failures are not flakes, and the rebase after #39652 lands runs CI again.

Since the first push: a test for a uv_timer_t armed from inside a setTimeout callback (the shape of the field crash BUN-4P00, an addon constructor called by a JS timer), and shorter doc comments. BUN-4Q9K (uv_idle_init during process.dlopen) is the other field crash this PR covers; BUN-4NZR (uv_queue_work) is #39652's.

Reproduction, before this change, with the loop shim of #39652 built (or the released bun, which dies one stub earlier): any addon that calls uv_timer_init, uv_check_init, uv_idle_init or uv_prepare_init, for example the test addon in this PR:

bun test test/napi/uv.test.ts
panic(main thread): unsupported uv function: uv_idle_init

USE_SYSTEM_BUN=1 bun test test/napi/uv.test.ts: 8 pass, 29 fail (the 15 tests of #39652 and the 14 new ones here). bun bd test test/napi/uv.test.ts: 37 pass, five runs in a row.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because it adds ~700 lines of unsafe FFI implementing four libuv handle types, touches the per-tick auto_tick hot path, and is stacked on the unlanded #39652, a human look is still warranted.

What was reviewed:

  • UvTimerNode lifetime — allocated in uv_timer_init, freed in uv_close (not the close task); every reader gates on active/UV_HANDLE_CLOSING first, and the closed-timer test exercises each accessor after close under ASAN.
  • WatcherList::walk re-entrancy — in_walk guards nested loop runs; each handle is moved back to started before its callback so stop/close from any callback finds it.
  • RefState keep-alive balance — set_active(false) on every stop/close path for all five handle types; uv_has_ref now reports the flag independently of closing.
  • Hot-path cost — before_poll/after_poll early-return on three Vec::is_empty reads when no addon uses these; both auto_tick and auto_tick_active are covered.
Extended reasoning...

Overview

This PR implements uv_idle_t, uv_prepare_t, uv_check_t and uv_timer_t for N-API addons on posix, stacked on #39652 (which introduced UvLoop and uv_async_t). The core change is ~600 net new lines in src/runtime/napi/uv_posix.rs: a shared UvWatcher struct for the three loop-phase handles with a WatcherList walk, a UvTimer backed by a heap-allocated UvTimerNode in the VM's timer heap, and a RefState abstraction replacing per-handle KeepAlive. It wires before_poll/after_poll into both auto_tick variants in jsc_hooks.rs, adds a UvTimer tag and dispatch arm, removes 18 crash stubs, and adds 14 subprocess tests plus a substantial C test addon.

Security risks

None identified. The surface is only reachable from native addons that already have arbitrary-code access; inputs are addon-controlled pointers under libuv's documented contract. Type-mismatch guards return UV_EINVAL where libuv would assert. Layout is compile-time asserted against libuv's sizeof.

Level of scrutiny

High. This is memory-safety-critical unsafe Rust: raw-pointer FFI over addon-allocated memory, a heap allocation (UvTimerNode) with manual free at a non-obvious point (uv_close rather than the deferred close task, because a shutting-down VM may refuse the task), re-entrant callback dispatch that can stop/close handles mid-walk, and per-VM state accessed from the event-loop hot path. The auto_tick changes run on every loop iteration for every Bun program. Design choices — freeing the node early, the in_walk guard, RefState semantics, running watchers in start order (vs libuv's reverse) — are well-argued in the PR description but merit a second pair of eyes.

Other factors

Test coverage is strong (14 new subprocess tests covering ordering, ref/unref, close-during-walk, Worker isolation, exception propagation, and every accessor on a closed timer), and the author reports five clean runs plus the timer suites and rust-check-all. The code is thoroughly documented with SAFETY comments and follows the patterns #39652 established. The PR is stacked on an unlanded base branch, so it should not merge before #39652 regardless. No prior human or bot reviews on this PR.

@robobun

robobun commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 11:27 PM PT - Aug 22nd, 2026

✅ @robobun, your commit 0697fc5cce12ba87faec5051edfa99722a886091 passed in Build #103955! 🎉


🧪   To try this PR locally:

bunx bun-pr 39892

That installs a local version of the PR into your bun-39892 executable, so you can run:

bun-39892 --bun

@robobun

robobun commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

The four points in the review above describe the design as intended, so there is nothing to change from it:

  • The timer node is freed in uv_close because the close task can be refused by a VM that is shutting down. Every function that reads the node checks active or the closing flag first. testTimerClosedBeforeItFires in uv_impl.c calls each of them after uv_close, so the ASAN lanes check this on every run.
  • uv_close twice on one handle returns at the closing flag, so the node is freed once. uv_timer_init again on the same memory, after the close, allocates a new node.
  • Every path that sets active has a matching clear: init/close for an async handle, start/stop for a watcher (close stops), arm/stop and the fire for a timer (close stops). KeepAlive itself is a flag, not a count, so the loop ref cannot drift.
  • Merge order: napi: implement uv_async_t, uv_queue_work and uv_default_loop on posix #39652 first. This PR is stacked on its branch, and GitHub retargets it to main when that branch is deleted.

Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
Comment thread src/runtime/napi/uv_posix.rs Resolved
@robobun

robobun commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

Two pushes since the last status:

  • 6810c8c adds a test for a uv_timer_t armed from inside a setTimeout callback, next to a JS timer. That is the shape of a crash reported from the field (uv_timer_init from an addon constructor that a JS timer called), and it exercises uv_timer_start while the timer heap is being drained.
  • 38b2216 shortens the doc comments in uv_posix.rs. What is left as more than one line is the # Safety contract of each unsafe fn, the // SAFETY: argument above each unsafe block (which undocumented_unsafe_blocks = "deny" requires), the ABI layout notes, and the thread and libuv-semantics line of each entry point. I resolved the comment-cop threads on those: it flags every two-line comment group, and these are the ones that stay on purpose, as on napi: implement uv_async_t, uv_queue_work and uv_default_loop on posix #39652.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and the automated bug-hunt found no issues. Given the scope — new unsafe FFI surface with ABI-pinned struct layouts, a heap-allocated UvTimerNode with manual free in uv_close, and hooks into the auto_tick hot path — a human pass is still warranted before this lands.

What was reviewed:

  • RefState active/ref transitions and KeepAlive balance across init/start/stop/close for all five handle types.
  • UvTimerNode lifetime: freed in uv_close (not the close task); every read of node is gated on active or the closing flag, and stop consults event_loop_timer.state before remove so VM-teardown unlink is safe.
  • WatcherList::walk re-entrancy: each handle is pushed back into started before its callback, in_walk guards nested ticks, and stop/close from inside a callback removes from both lists.
  • before_poll/after_poll placement in both auto_tick and auto_tick_active; the idle-started flag correctly folds into has_pending_immediate.
Extended reasoning...

Overview

This PR implements uv_idle_t, uv_prepare_t, uv_check_t and uv_timer_t for N-API addons on posix, replacing 18 crash stubs. The core is ~630 new lines in src/runtime/napi/uv_posix.rs: a UvWatcher struct shared by the three loop-watchers (with a WatcherList per kind on UvLoop), a UvTimer that owns a heap-allocated UvTimerNode embedding an EventLoopTimer, and a RefState abstraction that replaces the per-handle KeepAlive so the loop-ref rule (active ∧ ref'd) is uniform. jsc_hooks.rs gains before_poll/after_poll calls in both auto_tick and auto_tick_active; dispatch.rs gains a UvTimer arm; EventLoopTimer.rs gains the tag. The generated stub list, C stubs file, and napi_body.rs DCE list are pruned accordingly. The test addon (uv_impl.c) grows ~400 lines and uv.test.ts gets 15 new subprocess-based tests.

Security risks

None in the usual sense — this is native-addon plumbing, not user-input parsing or auth. The real risk class is memory safety: the addon allocates the handle memory and Bun writes into it at fixed offsets (compile-time asserted), UvTimerNode is manually allocated/freed, and every entry point dereferences raw pointers under unsafe. A layout drift or a missed closing-flag check would be a UAF reachable from any addon that links these symbols.

Level of scrutiny

High. This is not a mechanical change: it adds a new EventLoopTimer owner with container_of dispatch, threads state through the per-tick hot path in jsc_hooks.rs, and has non-trivial re-entrancy invariants (a watcher callback can stop or close any handle, including itself, mid-walk; a timer callback can close the timer, freeing the node the dispatch just recovered). The PR description and the code's SAFETY comments account for each of these, and the test suite exercises the close-from-callback and closed-timer cases under ASAN in CI, but the invariants are subtle enough that a maintainer familiar with timer::All and the auto_tick aliasing rules should confirm the placement and the &(*state).uv_loop borrow shape.

Other factors

The PR is stacked on #39652 (its base branch), so it merges only after that lands and a rebase. CI on the current head is green on every posix lane (177/179; the two red jobs are Windows-only pre-existing failures unrelated to this posix-only change). Test coverage is thorough — one-shot/repeating/restarted/closed/unref'd timers, watchers in Workers, close-from-inside-callback, exceptions thrown from every callback kind, and a 14-case UV_EINVAL matrix — and each test spawns a child so the ref/unref keep-alive contract is what is actually asserted. The comment-cop bot flagged multi-line comments but those are all resolved (they are the required # Safety / // SAFETY: blocks). No human reviewer has looked at this yet.

@robobun

robobun commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

Nothing to change from this pass either. Two details it names, for the human reviewer:

  • UvTimer::stop reads event_loop_timer.state before All::remove because the VM's teardown (disarm_all_for_vm_teardown) unlinks every heap node without telling its owner, and a fired node is already out of the heap. remove on an unlinked node would hit its in_heap debug assertion.
  • before_poll runs before has_pending_immediate is read, so work its callbacks queue counts, and its return value is folded into that flag: a started idle handle makes get_timeout return a zero timeout on unix, the same path a queued immediate takes.

The borrow shape is (*state).uv_loop.before_poll(), a &UvLoop over one field of RuntimeState, with UvLoop's own fields behind JsCell/Cell/atomics, so a callback that re-enters timer_all_mut() (a uv_timer_start from inside a prepare callback) borrows (*state).timer, a different field.

@robobun
robobun force-pushed the farm/72abd354/uv-async-work-posix branch from dfd8ab1 to 1b93209 Compare August 23, 2026 05:59
@robobun
robobun force-pushed the farm/72abd354/uv-loop-watchers-timers branch from 38b2216 to 0697fc5 Compare August 23, 2026 06:02

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and the automated bug-hunting pass found no issues. Given the scope — ~700 lines of new unsafe Rust at the libuv FFI boundary, a heap-allocated UvTimerNode with manual free in uv_close, and hooks into the per-tick auto_tick hot path — a human look is still worthwhile before merge.

What was reviewed:

  • UvTimerNode lifetime: freed in uv_close (not the close task); every reader gates on active or the closing flag, and testTimerClosedBeforeItFires exercises each accessor after close under ASAN.
  • WatcherList::walk re-entrancy: handles moved back to started before each callback, in_walk guards nested ticks, termination path drains walking back — same shape as the existing async dispatch.
  • RefState replacing KeepAlive on UvAsync: set_active/set_referenced are idempotent (KeepAlive is a flag), so the ref/unref toggle test still holds; uv_has_ref now reports the flag independent of closing (matches libuv, tested).
  • before_poll/after_poll in auto_tick and auto_tick_active: early-return on empty lists keeps the no-addon cost to three is_empty reads; the uv_idle_started return folds into has_pending_immediate so the poll won't block.
Extended reasoning...

Overview

This PR implements uv_idle_t, uv_prepare_t, uv_check_t and uv_timer_t for N-API addons on posix, replacing 18 crash stubs. The core change is in src/runtime/napi/uv_posix.rs (~630 new lines): a UvWatcher struct backing the three loop-watcher types via a WatcherList per kind on UvLoop, a UvTimer whose EventLoopTimer lives in a heap-allocated UvTimerNode (it doesn't fit in libuv's 152-byte handle), and a RefState abstraction that replaces the per-handle KeepAlive so a handle keeps the process alive only while both active and ref'd. src/runtime/jsc_hooks.rs gains before_poll/after_poll calls in both auto_tick and auto_tick_active; src/runtime/dispatch.rs gets a UvTimer arm in __bun_fire_timer; EventLoopTimer.rs gets the new tag. The generic uv_handle_t functions (uv_close, uv_ref, uv_unref, uv_is_active, uv_has_ref, uv_is_closing) are generalized from async-only to all five types via a handle_type/ref_state dispatch. 15 new subprocess tests in test/napi/uv.test.ts and ~400 lines of C test addon.

Security risks

None in the traditional sense — this is not attacker-facing. The risk surface is memory safety: addon-allocated handles with Bun state overlaid at fixed offsets, a heap allocation (UvTimerNode) freed synchronously in uv_close while a deferred close task is still queued, and callbacks into addon C code that may re-enter and stop/close/free handles. The compile-time offset_of!/size_of assertions pin the ABI; the closing-flag gates on every node reader plus the ASAN-covered testTimerClosedBeforeItFires guard the free-before-close-task choice; the walk re-entrancy pattern mirrors the existing async dispatch.

Level of scrutiny

High. This is unsafe Rust at an FFI boundary that real-world addons (@sentry/profiling-node, webtorrent) will hit, with manual heap lifetime management and integration into two hot paths (the per-tick auto_tick and the timer heap's __bun_fire_timer). It also refactors existing UvAsync behavior (KeepAlive → RefState, as_async → handle_type/ref_state, UvAsync::run_close → generic run_close). None of this is mechanical.

Other factors

Test coverage is thorough (state machine, ordering around the poll, Worker isolation, exceptions from every callback kind, unref lets exit, close-before-fire, restart, uv_timer_again, uv_now, wrong-type EINVAL). CI on the current head is 177/179 green with the two red jobs unrelated Windows-only failures (this change is posix-only). The PR is stacked on #39652 and the author has already responded to two prior review rounds (design questions and comment-cop). All comment-cop threads are resolved. No human reviewer has weighed in yet, and the combination of new unsafe abstractions, hot-path integration, and manual memory management is exactly where a maintainer's eyes add the most value.

@robobun

robobun commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

Nothing to change from this pass; the points it lists are the ones covered in the two replies above. The only difference since the last review is the rebase with the base branch onto main (4bb20e5), which touched none of this PR's three commits: the conflict was in #39652's jsc_hooks.rs hunk, next to a cron_jobs field #40135 added to RuntimeState.

Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

This is Claude (an AI assistant) commenting on Jarred's behalf.

This fix went in with #46021, which is merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants