Skip to content

macros: keep visited values alive so a reused address does not get another value's Expr - #42657

Closed
robobun wants to merge 9 commits into
mainfrom
robobun/815ef7e6/macro-root-visited-values
Closed

robobun wants to merge 9 commits into
mainfrom
robobun/815ef7e6/macro-root-visited-values

Conversation

@robobun

@robobun robobun commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • A macro result with getters that return a new array, object or promise gets wrong values inlined, with no error. On 1.4.3-canary, 8 of 12 values are wrong.
  • visited: HashMap<JSValue, Expr> (src/js_parser_jsc/Macro.rs:491) is keyed by cell address and does not keep the cell alive. After a GC, a new value can get a dead value's address and its Expr.

Fix

  • VisitMap is now a struct that owns the map and a MarkedArgumentBuffer. Its get_or_put and insert append each new key, so no insertion can skip its root.
  • MarkedArgumentBuffer::append from Rust now crashes if the buffer cannot grow. Before, JSC dropped the root.
  • Same class, not here: Bun.YAML.stringify (YAML.stringify: keep visited collections alive so a reused address is not taken for an alias #42578).
  • Verified: 1 new test in test/bundler/transpiler/macro-test.test.ts that fails without the fix. Self-reviewed: 9 concerns raised, 9 addressed.

Background

  • Run::coerce builds the AST node (Expr) that replaces a macro call. Getters run during that walk, so a GC can run too.
  • A JSValue of an object is the address of its GC cell. A MarkedArgumentBuffer is a JSC list whose entries are GC roots.
  • Considered: forget a value when the walk leaves it. A repeated value is read once today, so that changes results.

Downsides

  • Every macro call pays one append per visited array, object or promise (23 to 27 instructions, x86_64). Above 8 values the buffer allocates once per doubling.
  • Getter-made values live until the walk returns: 49.6 MB for 1500 getters of 4096 numbers each, not 0.4 MB.
  • Every Rust caller of append now crashes on a failed growth: 27 call sites in 7 files.
Notes

Costs, with their basis:

  • append fast path: 23 instructions while the buffer is inline and 27 after it moved to the heap. Counted from the disassembly of MarkedArgumentBuffer__append in a release build with symbols (x86_64). The Rust caller adds the call and its argument setup. The count is from a release build before this PR: appendWithCrashOnOverflow adds a test of the overflow flag after the append.
  • Buffer growth: MarkedArgumentBuffer is MarkedVector<JSValue, 8>. expandCapacity doubles the capacity and allocates once per doubling (Source/JavaScriptCore/runtime/MarkedVector.cpp). A walk with at most 8 arrays, objects and promises makes no allocation. A growth fails only when the allocator returns no memory, or above 2^30 entries. The binding now uses appendWithCrashOnOverflow for that case, as WebKit's CloneSerializer does for its own root buffer (m_gcBuffer). The other Rust callers of append are in MarkdownObject.rs (14), shell_body.rs (4), YAMLObject.rs (3), MySQLValue.rs (2), ScopeFunctions.rs of the test runner (2), parse_args.rs (1) and udp_socket.rs (1).
  • Retention: measured with a full GC inside the last of 1500 getters, then heapStats().heapSize. Each getter returns 4096 numbers. Without the fix (1.4.3-canary 367d939): 421315 and 421507 bytes in two runs. With the fix (debug build): 49576614 bytes in both runs. With 1 number per getter: 0.39 MB against 0.48 MB. Values that are reachable from the macro result are alive for the whole walk anyway.
  • Binary size: no growth. The CI size check shows +0.0 KB at most on all 12 targets against the main canary build, for the first shape and for the VisitMap shape.
  • Not measured: instruction counts for a whole macro call, and wall-clock time. perf, valgrind, strace and bloaty are not available on the machine that ran this work, and it could not produce a release build of this branch.
  • With no Bun.gc call, 2000 getters give 1184 wrong values under bun --smol on the canary. More sizes are in the table of results below.

Designs weighed:

  • Forget a value when the walk leaves it. The XML, TOML and JSON5 serializers, console.log and the bun:test formatter do this with their JSValue-keyed maps, so they are not affected by this bug. Here, [v, v, v] with a counting getter on v gives 1, 1, 1 today. It would give 1, 2, 3, and a shared subtree would be walked once per occurrence.
  • A shared rooted map in bun_jsc for this walker and Bun.YAML.stringify. YAML.stringify: keep visited collections alive so a reused address is not taken for an alias #42578 owns that site, so the type would have one user here.
  • Root only the values that an accessor returned. That needs a new flag through JSPropertyIterator and JSArrayIterator to save one append per value.
  • REVIEW.md asks for a MarkedArgumentBuffer for values that are held across slow calls.
  • The first shape of this PR had one append call next to each of the three insertion sites in coerce. VisitMap replaced that, so that an insertion cannot skip its root. Its fields are private to a nested module, as for the visited map in ConsoleObject.rs.

Provenance and reach:

  • A fuzz run found this. It is the sibling of the Bun.YAML.stringify case in YAML.stringify: keep visited collections alive so a reused address is not taken for an alias #42578. There is no user report.
  • The map has had unrooted keys since at least 2022-02 (423d208, the Zig version), so this is not a regression.
  • The trigger is limited to own enumerable accessors, on a plain object or on array indices, that return a new array, object or promise. A macro cannot return a Proxy (cannot coerce ProxyObject), so Proxy traps are not a trigger.
  • Values that are reachable from the macro result are alive for the whole walk anyway, so the buffer changes nothing for them. Values that a getter made now live until the walk returns.

Overlapping open PRs:

Small deterministic repro (bun index.ts):

// macro.ts
export function rows() {
  const o: Record<string, unknown> = {};
  for (let i = 0; i < 12; i++)
    Object.defineProperty(o, "k" + i, {
      enumerable: true,
      get() {
        if (i % 3 === 0) Bun.gc(true);
        return { id: i, rows: [i * 10, i * 10 + 1] };
      },
    });
  return o;
}

// index.ts
import { rows } from "./macro.ts" with { type: "macro" };
console.log(JSON.stringify(rows()));
// before: {"k0":{"id":0,...},"k1":{"id":1,...},"k2":{"id":2,...},"k3":{"id":0,...},"k4":{"id":1,...},...

Results on 1.4.3-canary (b993710), release, as wrong values of total.

With Bun.gc(true) in every third getter:

  • 300 getters that return { id, rows: <8 numbers> }: 295 of 300
  • 12 getters that return { id: i }: 8 of 12
  • 12 array index getters that return [i, i + 1]: 8 of 12
  • 12 getters that return Promise.resolve(i): 8 of 12

With no Bun.gc call, each getter returns { id, rows: <W numbers> }:

  • 1500 getters, W = 4096: 1232 of 1500
  • 3000 getters, W = 1024: 1985 of 3000
  • 20000 getters, W = 64: 8881 of 20000
  • 2000 getters, W = 64: 0 with bun index.ts on a fresh heap, 1184 of 2000 with bun --smol index.ts
  • 5000 getters, W = 64: 0 with bun index.ts on a fresh heap

So the count at which it starts depends on the heap state, not only on the size of the result.

Debug + ASAN build with the fix: the 300-getter script, the three 12-getter scripts and the 1500-getter script with no Bun.gc call all give 0 wrong.

Debug + ASAN build without the fix: the new test fails with the same 32 wrong lines as on the canary.

The new test covers each insertion site. With the first shape of this PR, removing any one of the three append calls made only the matching case fail (arrays, objects, promises in turn).

The Private arm of coerce had a visited lookup. Only arrays, objects and promises are inserted, and Tag::get returns Private only for a DOMWrapper cell, so that lookup could hit only through a reused address. It is removed.

Test files run on the debug build with the fix, 67 tests, all pass:

  • test/bundler/transpiler/macro-test.test.ts
  • test/bundler/transpiler/scope-mismatch-panic.test.ts
  • test/regression/issue/03830.test.ts
  • test/regression/issue/22656.test.ts (shared and circular references in macro results)
  • test/regression/issue/26360.test.ts
  • test/regression/issue/39900.test.ts

Also test/internal/source-lints/ (172 tests) and cargo clippy -p bun_js_parser_jsc --no-deps.

For the binding change, the suites of other Rust callers of append, on the same debug build: test/js/bun/yaml/yaml.test.ts, test/js/bun/md/md-react.test.ts, test/js/bun/md/md-render-callback.test.ts, test/js/node/util/parse_args/parse-args.test.mjs, test/js/node/util/parse_args/default-args.test.mjs, and three files in test/js/bun/shell/. 1605 pass. 1 fails by timeout: parseArgs extra tests > stress test > 100 mixed several times runs 1000 full GCs, which takes 19 s on a debug ASAN build against the 5 s limit. That test passes no option defaults, so it does not reach append.


[human-review] gate passed · iteration 0 · 3 files touched

fails on main (without fix)
ASAN without fix: 1 FAILED
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/bundler/transpiler/macro-test.test.ts
bun test v1.4.3 (367d939d9)

test/bundler/transpiler/macro-test.test.ts:
[macro] call escapeHTML
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call symbolKeys
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call escape
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] ca
... (truncated)

release without fix: 1 FAILED
bun test v1.4.3-canary.1 (367d939d9)

test/bundler/transpiler/macro-test.test.ts:
(pass) bun builtins can be used in macros [0.08ms]
(pass) latin1 string [0.03ms]
(pass) ascii string [0.01ms]
(pass) type coercion [0.25ms]
(pass) object with Symbol keys [0.05ms]
(pass) escaping [0.30ms]
(pass) utf16 string [0.02ms]
(pass) import aliases [0.03ms]
(pass) default import [0.02ms]
(pass) namespace import [0.03ms]
(pass) ireturnapromise [0.14ms]
(pass) object argument with a sparse numeric key [13.61ms]
(pass) object destructuring of a macro result keeps every bound property regardless of key order or repeated keys [10.08ms]
235 |   });
236 |   const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
237 |   expect(stderr).toBe("");
238 |   const indices = Array.from({ length: count }, (_, i) => i);
239 |   // Debug builds print "[macro] call <name>" to stdout before the script's own output.
240 |   expect(JSON.parse(stdout.trim().split("\n").pop()!)).toEqual({
                                                             ^
error: expect(received).toEqual(expected)

  {
    "arrays": [
      [
        0,
        1,
      ]
... (truncated)
passes on PR (with fix)
ASAN with fix: all passed
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/bundler/transpiler/macro-test.test.ts
bun test v1.4.3 (367d939d9)

test/bundler/transpiler/macro-test.test.ts:
[macro] call escapeHTML
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call symbolKeys
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call identity
[macro] call escape
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] call addStrings
[macro] ca
... (truncated)

release with fix: all passed
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped)
  target       linux-x64-gnu
  build type   Release
  build dir    ./build/release
  revision     08e4f2c9ad
  features     lto, baseline

23 deps, 136 codegen, 1176 objects in 1302ms

ninja: Entering directory `/workspace/bun/build/release'
[1/4] fetch lolhtml
[lolhtml] up to date
[2/4] fetch rust-argon2
[rust-argon2] up to date
[2/4] cargo plan → /workspace/bun/build/release/rust-target/plan.json
244 units: 172 lib, 16 proc-macro (host), 19 custom-build (host), 15 run custom-build, 17 lib (host), 4 run custom-build (host), 1 rlib
[3/4] reconfigure
[1/1499] mkdir stamps
[2/1499] mkdir codegen
[3/1499] install /workspace/bun
bun install v1.4.3-canary.1 (367d939d9)

Checked 26 installs across 65 packages (no changes) [21.00ms]
[4/1499] install /workspace/bun/packages/bun-error
bun install v1.4.3-canary.1 (367d939d9)

Checked 1 install across 2 packages (no changes) [3.00ms]
[5/1499] install /workspace/bun/src/node-fallbacks
bun install v1.4.3-canary.1 (367d939d9)

Checked 111 installs across 104 packages (no changes) [50.00ms]
[6/1499] rustc unicode_ident 
[7/1499] gen bake.{client
... (truncated)
diff hotspot
src/js_parser_jsc/Macro.rs                       | 77 ++++++++++++++++++------
 src/jsc/bindings/MarkedArgumentBufferBinding.cpp |  3 +-
 test/bundler/transpiler/macro-test.test.ts       | 54 +++++++++++++++++
 3 files changed, 114 insertions(+), 20 deletions(-)

gate history · 2 passed · 0 rejected · iteration 0

evidence per changed file
file                                              reads  edits  tests
src/js_parser_jsc/Macro.rs                            5     11     37
src/jsc/bindings/MarkedArgumentBufferBinding.cpp      1      1     37
test/bundler/transpiler/macro-test.test.ts            2      2     37

The walk that turns a macro result into AST nodes caches the node of
each array, object and promise in `visited`, keyed by cell address.
The map does not keep the cell alive. A value that only an accessor
returned is garbage when the walk leaves it. After a GC, a new value
can get the same address, and the walk gives it the cached node of
the dead value.

Run the walk inside a MarkedArgumentBuffer and append each key of
`visited` to it. A live cell keeps its address, so no other value can
equal a key.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: oven-sh/bun/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 154cc71c-10b6-4a72-81d2-31b78087e24b
📥 Commits

Reviewing files that changed from the base of the PR and between d67c3b1 and 65edd03.

📒 Files selected for processing (2)
  • src/js_parser_jsc/Macro.rs
  • src/jsc/bindings/MarkedArgumentBufferBinding.cpp

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.


Walkthrough

Macro runs now retain newly visited JavaScript values in a marked argument buffer. A regression test triggers garbage collection while creating getter-backed array, object, and promise values, then checks the inlined results.

Changes

Macro value rooting

Layer / File(s) Summary
Root visited values during macro runs
src/js_parser_jsc/Macro.rs, src/jsc/bindings/MarkedArgumentBufferBinding.cpp, test/bundler/transpiler/macro-test.test.ts
run_async passes a MarkedArgumentBuffer to Run. VisitMap roots values only when it inserts a new key. Cache lookups pass JSValue by value. The binding crashes if the buffer cannot grow. The regression test checks 12 distinct results with garbage collection during value creation.

Suggested reviewers: jarred-sumner

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 65edd

This change fixes macro results being wrongly reused after garbage collection. It keeps visited values alive until a macro walk finishes, which can raise memory use during large walks. No merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: keeping visited macro values alive to prevent address reuse from returning an incorrect cached expression. It is specific, though somewhat long.
Description check ✅ Passed The description explains the bug, fix, trade-offs, and verification results. It does not use the template’s exact headings, but it covers both what the PR does and how the author verified it.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status

Reproduced on 1.4.3-canary (b993710) and on a debug build of main without the fix. The fixture is a macro whose result has 12 getters. Each getter returns a new object, array or promise, and every third getter calls Bun.gc(true) first. 8 of the 12 inlined values are wrong in each of the three cases.

The new test in test/bundler/transpiler/macro-test.test.ts runs that fixture. It fails on both builds and passes with the fix. With no Bun.gc call, 2000 getters give 1184 wrong values under bun --smol on the canary.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — targeted GC-rooting fix that follows the prescribed MarkedArgumentBuffer pattern for JSValues held across calls that can GC.

What was reviewed:

  • MarkedArgumentBuffer::new scoping in run_async: the buffer's C++ stack lifetime encloses the entire runner.run(result) walk, so appended keys stay rooted until visited is dropped.
  • append placement in each coerce arm: Array/Object root before the iterator recurses (before GC can run); Promise's value is on-stack through wait_for_promise/recursion and is rooted before returning to the next sibling.
  • Test: tempDir + bunExe/bunEnv, await using spawn, concurrent stdout/stderr/exited drain, stderr/content asserted before exitCode, .toEqual on parsed JSON, and covers all three memoized shapes (object/array/promise) with Bun.gc(true) forcing address reuse.
Extended reasoning...

Overview

This PR fixes a GC-safety bug in the macro-result → AST walker (Run in src/js_parser_jsc/Macro.rs). The walker memoizes each visited array/object/promise in visited: HashMap<JSValue, Expr> keyed by cell address, but did not root those keys. A getter-produced value could be collected mid-walk and its address reused by a later value, which then false-hit the memo and got the earlier value's Expr inlined. The fix adds a visited_roots: &mut MarkedArgumentBuffer to Run, wraps runner construction in MarkedArgumentBuffer::new(|visited_roots| { ... }), and appends each newly-memoized JSValue to the buffer. A new subprocess test in test/bundler/transpiler/macro-test.test.ts exercises 12 lazily-computed getters per shape (object, array, promise) with Bun.gc(true) on every third read.

Security risks

None. This is a correctness/memory-safety fix in the transpiler's macro evaluator; it adds GC roots (strictly safer) and does not touch auth, crypto, network, or untrusted-input parsing paths. The worst-case failure mode of the change itself is redundant rooting, which is harmless.

Level of scrutiny

Moderate. GC-safety changes in native code warrant careful reading, and REVIEW.md explicitly names this pattern ("MarkedArgumentBuffer for values accumulated across slow calls — never raw JSValues in … std containers"). I verified: (1) MarkedArgumentBuffer::new is a scoped-borrow constructor whose C++ stack buffer lives for the closure's duration, which fully encloses runner.run(result) and the drop of visited; (2) the Array/Object arms append immediately after get_or_put returns not-found and before entering JSArrayIterator/JSPropertyIterator (which can invoke getters and GC); (3) the Promise arm's value remains on the Rust stack through wait_for_promise and the recursive run(promise_result), then is appended before returning, so no sibling can reuse its address; (4) the closure's return type flows through ctx.r.unwrap() unchanged, preserving run_async's signature and error propagation.

Other factors

The diff is ~25 net lines, mechanical, and matches the established in-tree MarkedArgumentBuffer::new idiom. The test follows every harness convention (tempDir, bunExe/bunEnv, await using spawn, concurrent pipe drain, assert output before exit code, .toEqual on structured data, small deterministic workload with forced GC rather than sleeps). Changed files are not CODEOWNER-gated. The bug hunt ran to dry_streak with no findings and no candidates ruled out; the PR timeline has no outstanding third-party objections.

@robobun

robobun commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 6:47 PM PT - Oct 5th, 2026

❌ @robobun, your commit 08e4f2c has 1 failures in Build #123480 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 42657

That installs a local version of the PR into your bun-42657 executable, so you can run:

bun-42657 --bun

@robobun

robobun commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

This bug also reproduces with no Bun.gc call. Only the collection timing matters. The test in this PR calls Bun.gc(true) inside the getters, so a second test without it would pin the natural form.

Repro, run with bun --no-cache use.ts:

// m.ts
export function table() {
  const o: any = {};
  const N = +(process.env.MN || 3000);
  for (let i = 0; i < N; i++)
    Object.defineProperty(o, "k" + i, {
      enumerable: true,
      get() {
        return { id: i, rows: Array.from({ length: 40 }, (_, j) => i * 100 + j) };
      },
    });
  return o;
}

// use.ts
import { table } from "./m.ts" with { type: "macro" };
const t: any = table();
let wrong = 0, n = 0;
for (const k in t) {
  const i = +k.slice(1);
  n++;
  if (t[k]?.id !== i || t[k]?.rows?.[39] !== i * 100 + 39) wrong++;
}
console.log(JSON.stringify({ n, wrong }));

wrong without the fix in this PR (expected 0):

build env MN=60 MN=200 MN=3000
1.4.3-canary b993710 default 0
1.4.3-canary b993710 BUN_JSC_collectContinuously=1 21 to 27 (5 runs, 17 ms each) 27 to 87 (8 runs, 35 ms each) 2302 (15 s)
1.4.3-canary b993710 BUN_JSC_slowPathAllocsBetweenGCs=7 5 (1 run) 2747 (35 s)
debug + ASAN build of main BUN_JSC_collectContinuously=1 23 and 23 (2.8 s each) 134 to 155 (3 runs, 14 s each) not run
debug + ASAN build of main BUN_JSC_slowPathAllocsBetweenGCs=7 15 0 not run

Suggested test: the same tempDir and Bun.spawn shape as the existing test, 60 getters, no Bun.gc, child env { ...bunEnv, BUN_JSC_collectContinuously: "1" }, and expect { n: 60, wrong: 0 }. At 60 values it failed in every run above on both builds, and it stays under 3 s on the debug build. BUN_JSC_slowPathAllocsBetweenGCs is not a reliable trigger at this size (0 wrong at MN=200 on the debug build).

@robobun

robobun commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

Merged main (bc7a813) into this branch so that CI runs against the current main. The diff is unchanged: the same 2 files, +75 -13.

This bug also reproduces with no Bun.gc call, no option and a small result. It is enough that each getter does ordinary work before it returns. The script is below. wrong is the number of properties in the importing module that carry another property's value (expected 0). Each cell is work per getter x getters, 3 runs unless noted.

build 1 KB x 3000 64 KB x 300 64 KB x 3000 1 MB x 30
1.4.3-canary 367d939, release 0, 0, 0 164, 164, 164 2842, 2843, 2843 20, 20, 20
main bc7a813, debug + ASAN not run 163, 163, 163 2843 (1 run) 20, 20, 20
main bc7a813 + this PR, debug + ASAN 0 (1 run) 0, 0, 0 0 (1 run) 0, 0, 0

With the fix, 1 MB x 3000 also gives 0 (1 run). test/bundler/transpiler/macro-test.test.ts on the merged tree: 28 pass, 0 fail.

Script
// m.ts
export function table() {
  const o: any = {}, size = +process.env.WORK!, N = +process.env.GETTERS!;
  for (let i = 0; i < N; i++)
    Object.defineProperty(o, "k" + i, {
      enumerable: true,
      get() {
        const work = Buffer.alloc(size, i & 255);
        return { id: i, first: work[0], rows: Array.from({ length: 40 }, (_, j) => i * 100 + j) };
      },
    });
  return o;
}

// use.ts
import { table } from "./m.ts" with { type: "macro" };
const t: any = table();
let right = 0, wrong = 0;
for (const k in t) {
  const i = +k.slice(1);
  if (t[k]?.id === i && t[k]?.rows?.[39] === i * 100 + 39) right++;
  else wrong++;
}
console.log(JSON.stringify({ rounds: right + wrong, right, wrong }));
WORK=65536 GETTERS=300 bun use.ts

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@robobun

robobun commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

CI state after the merge with main: the diff is green, and the red tests are not related to this change. This PR touches only src/js_parser_jsc/Macro.rs and test/bundler/transpiler/macro-test.test.ts. No macro test failed on any lane in the two runs.

  • Build 122831 (460d12c): 180 of 181 jobs passed. Red: test/js/web/workers/worker-terminate-lifetime.test.ts on darwin x64. The same test was red in 4 and passed on retry in 10 of the last 15 failed builds of other branches.
  • Build 122873 (9d6b435, one empty retrigger commit): 180 of 182 jobs passed. Red: test/js/node/net/node-net.test.ts and test/js/sql/sql-close-pending-connection.test.ts on darwin 27 aarch64, and test/js/bun/spawn/spawn.test.ts on debian 13 x64-asan (this one also fails on main).

I will not push another retrigger. The four red tests are reported for triage.

VisitMap is now a struct that owns the map and the MarkedArgumentBuffer.
Its get_or_put and insert append a new key to the buffer, so every
insertion roots its key in one place. Run::coerce is the same as on main
again: the three append calls next to the insertion sites are gone.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline finding, I also checked that every write into visited now goes through the VisitMap wrapper — the two get_or_put sites (arrays, objects) and the one insert site (promises) are the only stores, and the two remaining get calls are read-only, so no path leaves a key unrooted. Only cell-typed values (arrays, objects, promises) are ever stored, so append never sees a primitive, and the 'a borrow of the roots buffer is scoped by the MarkedArgumentBuffer::new closure that wraps the whole walk.

Extended reasoning...

The change replaces the macro walker's HashMap<JSValue, Expr> with a VisitMap that roots each new key in a MarkedArgumentBuffer spanning the whole walk, and adds a getter-plus-Bun.gc(true) regression test that drains stdout/stderr concurrently and asserts output before exit code. It touches no auth, crypto or injection surface. One nit finding is posted inline and a further verified finding was dropped from posting, so approval is withheld; the new VisitMap wrapper is new since the prior review, which is why a short ruled-out note is worth recording.

Comment thread src/js_parser_jsc/Macro.rs Resolved
cargo clippy denies a reference to an 8-byte Copy value (trivially_copy_pass_by_ref).
…grow it

JSC's append() drops the value and only records an overflow when the
buffer cannot grow. The Rust wrapper cannot read that flag, so the value
lost its GC root with no error. Use appendWithCrashOnOverflow, as
WebKit's CloneSerializer does for its own root buffer.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline note, two other things were checked and ruled out: the Promise arm's window between visited.get and visited.insert (src/js_parser_jsc/Macro.rs:878-918), where value is not yet in the map while self.run(promise_result) can run getters — value is a live local of that frame and promise_result stays reachable from it, so no address-reuse window opens there; and the switch to appendWithCrashOnOverflow in src/jsc/bindings/MarkedArgumentBufferBinding.cpp, which also changes the nine other Rust MarkedArgumentBuffer::append callers (shell, sql, YAML, Markdown, udp, parse_args, test runner) — it only differs when the buffer's heap growth fails, which Bun's C++ sites already treat as fatal.

Extended reasoning...

The diff wraps the macro result walk's JSValue-keyed memo map in a VisitMap that appends every new key to a stack-scoped MarkedArgumentBuffer, restructures Run::run_async so the walk runs inside that buffer's scope, and makes the shared Rust append binding crash on overflow instead of silently dropping the value; a subprocess test exercises getter-produced arrays, objects and promises with Bun.gc(true) between reads. No injection, auth or data-exposure surface is touched. The ruled-out items above are the only concerns examined that are not already covered by the inline comment.

Comment thread src/js_parser_jsc/Macro.rs Resolved
Only arrays, objects and promises are inserted into `visited`, and a
DOMWrapper cell never takes those arms. With every key alive, the lookup
for a DOMWrapper cell cannot hit. On main it could hit only through a
reused address.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the latest push and found no bugs; the two earlier nits (silent drop on append overflow, the dead visited lookup in the Private arm) are addressed by 65edd03 and 08e4f2c. Because the binding change switches every Rust MarkedArgumentBuffer::append caller (YAML, Markdown, parseArgs, shell, UDP) to crash-on-overflow and the rooting keeps getter-made values alive for the whole walk, a human look at those two tradeoffs is still worthwhile.

What was reviewed:

  • VisitMap::get_or_put/insert: the key is inserted and rooted before any call that can run JS; all three insertion sites (Array, Object, Promise) go through them, and Run has a single construction site.
  • Buffer lifetime: MarkedArgumentBuffer__run keeps the 8-slot inline buffer on the real stack (SUPPRESS_ASAN) and JSC registers the buffer in the heap's mark-list set once it spills to the heap, so both modes root; the test's 12 values per walk exercises both.
  • Removing the Private arm lookup: DOMWrapper cells are never inserted, so on the base branch it could only hit through the address reuse this PR removes — no behavior change.
  • Test: fresh subprocess, stdout/stderr/exited drained together, exact toEqual on the inlined values, matches the sibling tests' conventions.
Extended reasoning...

The change touches src/js_parser_jsc/Macro.rs (a ~45-line VisitMap wrapper that roots every memoized key in a MarkedArgumentBuffer, plus a lifetime on Run), a one-line change in src/jsc/bindings/MarkedArgumentBufferBinding.cpp from append() to appendWithCrashOnOverflow(), and one new regression test in test/bundler/transpiler/macro-test.test.ts. It touches no auth, crypto, injection or data-exposure surface; the sensitive surface is GC rooting of JSValues held across user-JS getter calls. The rooting mechanism and the removed Private-arm lookup check out against the JSC MarkedVector semantics and the map's insertion sites, and the PR has no CODEOWNER on the changed paths and no outstanding third-party objection. Defer rather than approve because the C++ binding change alters behavior for every other Rust append caller (crash instead of silent unroot on allocation failure) and the chosen design retains getter-made values until the walk returns, both of which are policy tradeoffs a maintainer should confirm.

Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

This is Claude (an AI assistant) commenting on Jarred's behalf.

This fix went in with #46021, which is merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants