Skip to content

[Forwardport] resolved default country selection issue while creating new customer … #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

rostyslav-hymon
Copy link
Owner

Original Pull Request

magento#13024
Backend Works

Description

Insert the "is_default" field country options based on website scope into country option array.
Used the "is_default" value in customer edit address form to pre selected the country.

Fixed Issues (if relevant)

  1. Default country selection issue while creating new customer from backend magento/magento2#3483: Default country selection issue while creating new customer from backend

Manual testing scenarios

  1. Fresh Install
  2. Tested in all Modes
  3. Ran Successfull Test Cases

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

rostyslav-hymon pushed a commit that referenced this pull request Mar 21, 2018
…ile creating new customer … #5 magento#14204

 - Merge Pull Request magento#14204 from rostyslav-hymon/magento2:2.3-develop-PR-port-13024
 - Merged commits:
   1. 255b682
   2. e37ae24
rostyslav-hymon pushed a commit that referenced this pull request Mar 21, 2018
rostyslav-hymon pushed a commit that referenced this pull request Mar 21, 2018
rostyslav-hymon pushed a commit that referenced this pull request Mar 21, 2018
Accepted Public Pull Requests:
 - magento#14210: [Forwardport] Inconsistent Redirect in Admin Notification Controller (by @dimonovp)
 - magento#14209: [Forwardport] Invoice grid shows wrong subtotal for partial items invoice. It shows order's subtotal instead if invoiced item's subtotal (by @AlexWorking)
 - magento#14207: [Forwardport] Make scope parameters of methods to save/delete config optional (by @mastiuhin-olexandr)
 - magento#14205: [Forwardport] Allow changing head and body element through xml layout updates (by @dimonovp)
 - magento#14204: [Forwardport] resolved default country selection issue while creating new customer � #5 (by @rostyslav-hymon)
 - magento#14203: [Forwardport] Use event object in 'ajax:addToCart' trigger when adding a product to the cart (by @mastiuhin-olexandr)
 - magento#14199: [Forwardport] Issue-13768 Fixed error messages on admin user account page after redirect for force password change (by @dimonovp)
 - magento#14194: [Forwardport] [FIX] small refactoring and removing not using variable from templates (by @mastiuhin-olexandr)
 - magento#14192: [Forwardport] magento#13820: IE11 minicart not updating on configurable pr� (by @mastiuhin-olexandr)
 - magento#14191: [Forwardport] Removed unnecessary protected member variables. (by @dimonovp)
 - magento#14190: [Forwardport] Modify Report processor to return 500 (by @AlexWorking)
 - magento#14185: [Forwardport] Added missing event parameter for proxy function on the search form submit (by @dimonovp)
 - magento#14184: [Forwardport] Add @api annotation to block argument marker interface (by @dimonovp)
 - magento#14214: [Forwardport] Fix $useCache for container child blocks (by @rostyslav-hymon)
 - magento#14212: [Forwardport] Fix typo in securityCheckers array (by @AlexWorking)
 - magento#14215: [Forwardport] magento#13899 Solve Canada Zip Code pattern (by @AlexWorking)
 - magento#14216: [Forwardport] Fix cache issue for currencies with no symbol (by @dimonovp)
 - magento#14213: [Forwardport] Added alias to block 'product.info.description' (by @mastiuhin-olexandr)


Fixed GitHub Issues:
 - magento#13804: Invoice grid shows wrong subtotal for partial items invoice. It shows order's subtotal instead if invoiced item's subtotal (reported by @ankurvr) has been fixed in magento#14209 by @AlexWorking in 2.3-develop branch
   Related commits:
     1. 0bfc3e1

 - magento#4454: CMS Page with <head> in layout update xml (reported by @zhiyicai) has been fixed in magento#14205 by @dimonovp in 2.3-develop branch
   Related commits:
     1. 822c6e9

 - magento#3483: Default country selection issue while creating new customer from backend (reported by @keyurshah070) has been fixed in magento#14204 by @rostyslav-hymon in 2.3-develop branch
   Related commits:
     1. 255b682
     2. e37ae24

 - magento#13768: Expired backend password - Attention: Something went wrong (reported by @janssensjelle) has been fixed in magento#14199 by @dimonovp in 2.3-develop branch
   Related commits:
     1. 4df41e1

 - magento#13820: IE11 minicart not updating on configurable product page (ES6) (reported by @Pumppa) has been fixed in magento#14192 by @mastiuhin-olexandr in 2.3-develop branch
   Related commits:
     1. 6d4065a

 - magento#11512: Incorrect use of 503 status code (reported by @andrewhowdencom) has been fixed in magento#14190 by @AlexWorking in 2.3-develop branch
   Related commits:
     1. 72c502f

 - magento#13791: Submitting search form (mini) with empty value throws error on preventDefault (reported by @koenner01) has been fixed in magento#14185 by @dimonovp in 2.3-develop branch
   Related commits:
     1. 808487b

 - magento#13899: Postal code (zip code) for Canada should allow postal codes without space (reported by @sl02) has been fixed in magento#14215 by @AlexWorking in 2.3-develop branch
   Related commits:
     1. c87b104
     2. ac37727
     3. bda63c7
     4. cb04f93
@rostyslav-hymon rostyslav-hymon merged commit e37ae24 into 2.3-develop Mar 21, 2018
rostyslav-hymon pushed a commit that referenced this pull request Mar 22, 2018
removed request_schema attribute added in previous commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants