[Forwardport] Add getters to product image builder #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser account page after redirect for force password change magento#14199
…ing variable from templates magento#14194
…n configurable pr… magento#14192
…ction on the search form submit magento#14185
Order emails are sent using observers on the `sales_model_service_quote_submit_success` event, but only in the `webapi_rest` and `webapi_soap` areas. When customers checkout with Braintree Paypal the order placement occurs in the `frontend` area with a request to `Magento\Braintree\Controller\Paypal\PlaceOrder`, so these orders were not sent a new order email. Fixes magento#13778 Fixes magento#12792
magento#14216 - Merge Pull Request magento#14216 from dimonovp/magento2:2.3-develop-PR-port-13894 - Merged commits: 1. 2ed4698
- fix static failures
- reverted back the logic for resolution of the processors - added sort order of the injected objects
…on to include TAX in rate magento#14217 - Merge Pull Request magento#14217 from gwharton/magento2:2.3-develop-ups - Merged commits: 1. 933f478
- fixed static errors - fixed sort order of the injected objects
# Conflicts: # app/code/Magento/Ui/view/base/ui_component/etc/definition.xml
- fixed unit tests - changed matching algorithm for request processors
- fixed static tests
…agento#14215 - Merge Pull Request magento#14215 from AlexWorking/magento2:2.3-develop-PR-port-13930 - Merged commits: 1. c87b104 2. ac37727 3. bda63c7 4. cb04f93
…14212 - Merge Pull Request magento#14212 from AlexWorking/magento2:2.3-develop-PR-port-13897 - Merged commits: 1. 7c51752
…o visible label magento#14383 - Merge Pull Request magento#14383 from rostyslav-hymon/magento2:2.3-develop-PR-port-14317 - Merged commits: 1. 8d52421
- Merge Pull Request magento#13517 from pmclain/magento2:feature/sidebar-qty - Merged commits: 1. 59078e2
… obsolete tools magento#14368 - Merge Pull Request magento#14368 from rostyslav-hymon/magento2:2.3-develop-PR-port-14091 - Merged commits: 1. 4853530 2. 632f89d
…AGETWO-71618-MediaGallery-From-Stage
Accepted Public Pull Requests: - magento#14383: [Forwardport] FR#7428 - Multiline fields in forms have no visible label (by @rostyslav-hymon) - magento#14387: [Forwardport] Format code (by @rostyslav-hymon) - magento#14345: Fix OptionsRepository API test to add option by attribute_id (by @bcerban) - magento#14329: Port: Fix for broken navigation menu on IE11 magento#14230 (by @sergiy-v) - magento#14343: Checkout module: Removing deprecated Message Manager method calls (by @Loxzibit) - magento#14341: magento/magento2: Updating deprecated message manager methods (by @JamelleG) Fixed GitHub Issues: - magento#7428: Multiline fields in forms have no visible label (reported by @navarr) has been fixed in magento#14383 by @rostyslav-hymon in 2.3-develop branch Related commits: 1. 8d52421 - magento#5580: Cannot add multiple options to configurable product via REST API (reported by @svines) has been fixed in magento#14345 by @bcerban in 2.3-develop branch Related commits: 1. 966d8bb
…diaGallery-From-Stage Fixing Unable to create folder in media gallery
…nk-ui-component Implemented [Ui Component] URL Input: External Link
Accepted Public Pull Requests: - magento#13517: Stop cast of item_qty to int (by @pmclain) - magento#14268: Update jQuery migrate to 1.4.1 (by @jonathanKingston) - magento#14368: [Forwardport] Remove sjparkinson/static-review and other obsolete tools (by @rostyslav-hymon) Fixed GitHub Issues: - magento#14138: Outdated package after upgrade sjparkinson/static-review is abandoned (reported by @woshka) has been fixed in magento#14368 by @rostyslav-hymon in 2.3-develop branch Related commits: 1. 4853530 2. 632f89d
…no-history [EngCom] Various fixes in Magento 2 core to support MSI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13414
Hello,
Description
I have added the attributes getter into the product image builder, class
Magento\Catalog\Block\Product\ImageBuilderin order to get them in a plugin for example. We may want to add some attributes and use$subject->getProduct()to get product's data.Fixed Issues (if relevant)
N/A.
Manual testing scenarios
N/A.
Contribution checklist