[Console] Update input.rst #16810

mohamedGasmii · 2022-05-18T18:10:15Z

VALUE_IS_ARRAY can't be used alone and must be combined with VALUE_REQUIRED or VALUE_OPTIONAL else
we will get InvalidArgumentException('Impossible to have an option mode VALUE_IS_ARRAY if the option does not accept a value.')

* 5.4: Remove reference to PHP Templates in translation

Hello, I think the condition `image_url is not null` is not enough as if we create a FileType form field without the `image_property` it causes an error. Adding `image_url is defined` is necessary because the variable `image_url` is only defined and passed to the view when `image_property` is already defined.

…amkhadiri1989) This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Form] Update create_form_type_extension.rst Hello, I think the condition `image_url is not null` is not enough as if we create a FileType form field without the `image_property` it causes an error. Adding `image_url is defined` is necessary because the variable `image_url` is only defined and passed to the view when `image_property` is already defined.  Commits ------- 85470c5 Update create_form_type_extension.rst

UTF8 is meant to be used when using PostgreSQL, and the example is mainly about MySQL. In the case of MySQL, utf8 is a deprecated charset and should not be used.

…greg0ire) This PR was merged into the 5.4 branch. Discussion ---------- [Doctrine] Recommend a better charset for MySQL UTF8 is meant to be used when using PostgreSQL, and the example is mainly about MySQL. In the case of MySQL, utf8 is a deprecated charset and should not be used.  Commits ------- 4f5845b Recommend a better charset for MySQL

This PR was merged into the 5.4 branch. Discussion ---------- [Uid] Update uid.rst Reference symfony/symfony#44938 (comment)  Commits ------- 91872e4 Update uid.rst

* 5.4: Recommend a better charset for MySQL Update create_form_type_extension.rst Update uid.rst

* 4.4: remove reference to not existing YAML dumper flag

…ute (94noni) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] Update route from annotation to attribute I was reading some doc around this notifier component and found this is worth it Commits ------- eaa7f02 Update route from annotation to attribute

* 4.4: Use `path` instead of `url` in SSI documentation

Updates the FQCN for DoctrineReceiver as the class moved in a Bridge namespace after Symfony 6.0

…n 6.0 (AymDev) This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Messenger] Fix broken link to DoctrineReceiver in 6.0 Came across a broken link to the `DoctrineReceiver` class when building my Azure transport. Commits ------- 2036790 Fix broken link to DoctrineReceiver in Messenger

…smariegaborit) This PR was merged into the 5.4 branch. Discussion ---------- Encore : firewall replace with allowedHosts The firewall option was removed since webpack-dev-server V4.0.0 and replace with allowedHosts. https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#bug-fixes-15 Commits ------- 9dc01ff firewall option replace with allowedHosts

This PR was merged into the 5.4 branch. Discussion ---------- Update _ux-libraries.rst.inc I was reading some doc on twig/live component and arrived on this page, As it seems they are not alpha ordered, for me the Swup integration could be defined upper as it is a more global lib than the chart or dropzone Commits ------- 96df416 Update _ux-libraries.rst.inc

… (Jibbarth) This PR was merged into the 5.4 branch. Discussion ---------- [Lock] Fix code example for Doctrine based stores Just noticed examples code for DoctrineDbalStore and DoctrineDbalPostgreSqlStore still used the old Pdo*Store. Commits ------- 9829b13 [Lock] Fix code example for Doctrine based stores

* 4.4: [Config] Suggest avoiding new environments

* 5.4: [Config] Suggest avoiding new environments Fix broken link to DoctrineReceiver in Messenger remove reference to not existing YAML dumper flag Update _ux-libraries.rst.inc firewall option replace with allowedHosts Update route from annotation to attribute Use `path` instead of `url` in SSI documentation [Lock] Fix code example for Doctrine based stores

This PR was merged into the 5.4 branch. Discussion ---------- Update README.markdown Ref [Symfony Releases Calendar](https://symfony.com/releases) Commits ------- 2d6fa20 Update README.markdown

…e (mdoutreluingne) This PR was merged into the 5.4 branch. Discussion ---------- [Mailer] Update route from annotation to attribute For this PR i update route from annotation to attribute Commits ------- e66b990 Update route from annotation to attribute

* 5.4: Update README.markdown Update route from annotation to attribute

Hello, According to the `getLongestCommonBasePath` signature, the method accepts a variadic string parameter $paths and not an array. It means when calling the `Path::getLongestCommonBasePath` with an array, a `TypeError` occurs. I think even the PHPDoc of the `Path::getLongestCommonBasePath` should be updated too as it is mentionned that it can accept an array argument.

…989) This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Filesystem] Update filesystem.rst Hello, According to the `getLongestCommonBasePath` signature, the method accepts a variadic string parameter $paths and not an array. It means when calling the `Path::getLongestCommonBasePath` with an array, a `TypeError` occurs. I think even the PHPDoc of the `Path::getLongestCommonBasePath` should be updated too as it is mentionned that it can accept an array argument.  Commits ------- 2ebec3b Update filesystem.rst

* 5.4: Update filesystem.rst

* 4.4: Remove some unused links Remove usage of SymfonyCloud in favor of Platform.sh

Even if the default value is used

…om 6.0 docs (l-vo) This PR was merged into the 6.0 branch. Discussion ---------- [Security] Remove enable authenticator manager from 6.0 docs Related to symfony#16218 Commits ------- 1c76da8 Remove enable_authenticator_manager

* 4.4: Update doctrine.rst

* 5.4: Update doctrine.rst

* 4.4: Update the list of members of the CARE Team

* 5.4: Update the list of members of the CARE Team

…required even if the default value is used (l-vo) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Creating a route for logout is always required even if the default value is used According to https://symfony.com/doc/current/security.html#logging-out and the fact that there is no default logout route defined in Symfony (at least I didn't find one). Commits ------- cb96633 Creating a route for logout is always required

* 5.4: Creating a route for logout is always required

…r needed) (mdoutreluingne) This PR was merged into the 6.0 branch. Discussion ---------- [Lock] Removed RetryTillSaveStore class (no longer needed) Fixes symfony#16785 For this PR, I removed `RetryTillSaveStore` class, because this class became obsolete from Symfony 5.2 and was removed from Symfony 6.0 as shown [here](https://github.com/symfony/symfony/pull/38296/files#diff-14c53c18273c57073d28f8dd3b4fab7253f5df427aea52b9a1c0a815dea3bea2). Commits ------- 0ba643e Remove RetryTillSaveStore class

* 4.4: [Form] Fix an inversion between object and class

* 5.4: [Form] Fix an inversion between object and class

…rator when possible (HeahDude) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Use PHP-DSL `env()` configurator when possible  Fixes symfony#15223. Commits ------- e0e8a74 Use PHP-DSL `env()` configurator when possible

* 5.4: Use PHP-DSL `env()` configurator when possible

…norkunas) This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Security] Fix typehint in custom user provider Commits ------- 7fb76a5 [Security] Fix typehint in custom user provider

* 5.4: [Security] Fix typehint in custom user provider

VALUE_IS_ARRAY can't be used alone and must be combined with VALUE_REQUIRED or VALUE_OPTIONAL else we will get InvalidArgumentException('Impossible to have an option mode VALUE_IS_ARRAY if the option does not accept a value.')

OskarStark · 2022-05-20T11:12:55Z

console/input.rst

@@ -221,7 +221,7 @@ There are five option variants you can use:
    Accept either the flag (e.g. ``--yell``) or its negation (e.g.
    ``--no-yell``).

-You can combine ``VALUE_IS_ARRAY`` with ``VALUE_REQUIRED`` or


So the following would be correct?

You need to combine VALUE_IS_ARRAY with VALUE_REQUIRED or
VALUE_OPTIONAL like this::

Being a bit picky, the original sentence is also correct, "you can combine VALUE_IS_ARRAY", but ofc you first need VALUE_REQUIRED oder VALUE_OPTIONAL (note that these two are written before the VALUE_IS_ARRAY), but I am totally fine to make it more clear.

cc @javiereguiluz

What is confusing is that 'InputArgument::IS_ARRAY' and 'InputOption::VALUE_IS_ARRAY' can both be used combined and for both the same description is used 'You can combine...', so automatically i thought they both share the same logic, but only 'InputArgument::IS_ARRAY' can be used alone.
'You need to combine' it s more clear,
Thank you !

OskarStark · 2022-05-20T11:16:09Z

I think this should target 4.4

mohamedGasmii · 2022-05-23T19:43:12Z

I targeted 4.4 here: #16821

javiereguiluz and others added 30 commits February 15, 2022 09:47

Merge branch '5.4' into 6.0

b2b1eb5

* 5.4: Remove reference to PHP Templates in translation

Recommend a better charset for MySQL

4f5845b

UTF8 is meant to be used when using PostgreSQL, and the example is mainly about MySQL. In the case of MySQL, utf8 is a deprecated charset and should not be used.

Update route from annotation to attribute

eaa7f02

firewall option replace with allowedHosts

9dc01ff

Merge branch '5.4' into 6.0

270954d

* 5.4: Recommend a better charset for MySQL Update create_form_type_extension.rst Update uid.rst

Update _ux-libraries.rst.inc

96df416

Merge branch '4.4' into 5.4

054e9b3

* 4.4: remove reference to not existing YAML dumper flag

Merge branch '4.4' into 5.4

a5979b0

* 4.4: Use `path` instead of `url` in SSI documentation

Fix broken link to DoctrineReceiver in Messenger

2036790

Updates the FQCN for DoctrineReceiver as the class moved in a Bridge namespace after Symfony 6.0

Minor tweak

9a13511

Merge branch '4.4' into 5.4

156972d

* 4.4: [Config] Suggest avoiding new environments

Update route from annotation to attribute

e66b990

Update README.markdown

2d6fa20

minor symfony#16530 Update README.markdown (94noni)

b5857d7

This PR was merged into the 5.4 branch. Discussion ---------- Update README.markdown Ref [Symfony Releases Calendar](https://symfony.com/releases) Commits ------- 2d6fa20 Update README.markdown

Merge branch '5.4' into 6.0

03fc231

* 5.4: Update README.markdown Update route from annotation to attribute

Merge branch '5.4' into 6.0

ad9ddd2

* 5.4: Update filesystem.rst

Merge branch '4.4' into 5.4

ff3d402

* 4.4: Remove some unused links Remove usage of SymfonyCloud in favor of Platform.sh

mdoutreluingne and others added 21 commits May 7, 2022 17:59

Remove RetryTillSaveStore class

0ba643e

Remove enable_authenticator_manager

1c76da8

Creating a route for logout is always required

cb96633

Even if the default value is used

Merge branch '4.4' into 5.4

fc41af2

* 4.4: Update doctrine.rst

Merge branch '5.4' into 6.0

c03ef32

* 5.4: Update doctrine.rst

Merge branch '4.4' into 5.4

d2e3a46

* 4.4: Update the list of members of the CARE Team

Merge branch '5.4' into 6.0

15600c9

* 5.4: Update the list of members of the CARE Team

Merge branch '5.4' into 6.0

223351d

* 5.4: Creating a route for logout is always required

Merge branch '4.4' into 5.4

762622a

* 4.4: [Form] Fix an inversion between object and class

Merge branch '5.4' into 6.0

88b5cb7

* 5.4: [Form] Fix an inversion between object and class

Use PHP-DSL env() configurator when possible

e0e8a74

Merge branch '5.4' into 6.0

cd4f88c

* 5.4: Use PHP-DSL `env()` configurator when possible

Remove some unneeded versionadded directives

5eb3931

[Security] Fix typehint in custom user provider

7fb76a5

Merge branch '5.4' into 6.0

766077f

* 5.4: [Security] Fix typehint in custom user provider

Update input.rst

125124e

VALUE_IS_ARRAY can't be used alone and must be combined with VALUE_REQUIRED or VALUE_OPTIONAL else we will get InvalidArgumentException('Impossible to have an option mode VALUE_IS_ARRAY if the option does not accept a value.')

carsonbot added the Status: Needs Review label May 18, 2022

OskarStark reviewed May 20, 2022

View reviewed changes

OskarStark added the Console label May 20, 2022

carsonbot changed the title ~~Update input.rst~~ [Console] Update input.rst May 20, 2022

mohamedGasmii changed the base branch from 6.0 to 4.4 May 23, 2022 18:56

mohamedGasmii requested a review from xabbuh as a code owner May 23, 2022 18:56

mohamedGasmii closed this May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Update input.rst #16810

[Console] Update input.rst #16810

mohamedGasmii commented May 18, 2022

OskarStark May 20, 2022 •

edited

Loading

mohamedGasmii May 23, 2022 •

edited

Loading

OskarStark commented May 20, 2022

mohamedGasmii commented May 23, 2022

[Console] Update input.rst #16810

[Console] Update input.rst #16810

Conversation

mohamedGasmii commented May 18, 2022

OskarStark May 20, 2022 • edited Loading

Choose a reason for hiding this comment

mohamedGasmii May 23, 2022 • edited Loading

Choose a reason for hiding this comment

OskarStark commented May 20, 2022

mohamedGasmii commented May 23, 2022

OskarStark May 20, 2022 •

edited

Loading

mohamedGasmii May 23, 2022 •

edited

Loading