[Backport] Added unit test for CaptchaStringResolver #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepted Public Pull Requests: - magento#15515: [fix] dynamical assigned property in webapi (by @mhauri) - magento#15301: Refactor JavsScript for customer logout (by @patelnimesh1988) - magento#15512: Fixes in ui module (by @mhauri) - magento#15499: Issue 15469: Javascript error dropdowns.js (by @brian-labelle) - magento#15382: Fix for Magnifier in inside mode (by @kacperchara) Fixed GitHub Issues: - magento#15469: lib/web/mage/dropdowns.js fails when autoclose is set to true (reported by @brian-labelle) has been fixed in magento#15499 by @brian-labelle in 2.2-develop branch Related commits: 1. 31e3b63 - magento#4977: Magnifier doesn't work with mode set to inner (reported by @theycallmepepper) has been fixed in magento#15382 by @kacperchara in 2.2-develop branch Related commits: 1. c427ff1
- Merge Pull Request magento#15519 from saurabh-aureate/magento2:saurabh-patch-5 - Merged commits: 1. a57e830
…f screen when… magento#15459 - Merge Pull Request magento#15459 from hitesh-wagento/magento2:feature-ui-component-listing - Merged commits: 1. 2cc78bc
magento#15552 - Merge Pull Request magento#15552 from saurabh-aureate/magento2:saurabh-patch-7 - Merged commits: 1. 238f2e8
- Merge Pull Request magento#15549 from vgelani/magento2:typo-error-1 - Merged commits: 1. 1143e70
…nd Google Analytics is enabled
[chaika] MAGETWO-91327: Customer attributes length validation on form doesn't work
…s not remove it from… magento#15019
…97' into 2.2-develop-prs
…product magento#13862 - Merge Pull Request magento#13862 from avstudnitz/magento2:compare-success-message - Merged commits: 1. edd6062 2. 6c17f99 3. 4c1bd49
…97' into 2.2-develop-prs
Accepted Public Pull Requests: - magento#15322: ISSUE-11477 - fixed Swagger response for searchCriteria (by @idziakjakub) - magento#15320: issue/14056 - Coupon API not working for guest user (by @Hypo386) - magento#12626: Fixed condition with usage "hack" isPostRequest method (by @pusachev) - magento#15661: Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies (by @ankurvr) - magento#15689: magento#15588 Fixed incorrect image urls in multistore xml sitemap (by @StevenGuapaBV) - magento#15826: Add missing table aliases to fields mapping for Customer Group filter� (by @radio) - magento#12935: Add Ability To Separate Frontend / Adminhtml in New Relic (by @mpchadwick) - magento#15019: [TASK] Solve issue magento#14966 - Disabling product does not remove it from� (by @lewisvoncken) - magento#15297: Fix typo in test method's name and test result (by @dmytro-ch) Fixed GitHub Issues: - magento#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria (reported by @careys7) has been fixed in magento#15322 by @idziakjakub in 2.2-develop branch Related commits: 1. 788485a - magento#14056: Coupon API not working for guest user (reported by @gnanasekaranl) has been fixed in magento#15320 by @Hypo386 in 2.2-develop branch Related commits: 1. 6ad9c03 2. 8b7bb58 - magento#15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies (reported by @ankurvr) has been fixed in magento#15661 by @ankurvr in 2.2-develop branch Related commits: 1. 56bcffb 2. 1c1e277 - magento#15588: Images in XML sitemap are always linked to base store in multistore (reported by @dvershinin) has been fixed in magento#15689 by @StevenGuapaBV in 2.2-develop branch Related commits: 1. 7b8fe3d 2. 498047c 3. 63ed864 4. 83ad777 5. 6a490a8 6. f1dd4e8 7. b7f8d28 - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15826 by @radio in 2.2-develop branch Related commits: 1. 83a8dea - magento#14966: Disabling product does not remove it from the flat index (reported by @ktruehl) has been fixed in magento#15019 by @lewisvoncken in 2.2-develop branch Related commits: 1. 0d35081 2. c6196d7 3. 2d6fb62 4. 38bd9d3 5. 219024c
…o\Framework\D… magento#15892 - Merge Pull Request magento#15892 from NamrataChangani/magento2:nps-comment-issue-1 - Merged commits: 1. 811bf10 2. 27df0e9
- Merge Pull Request magento#15891 from saurabh-aureate/magento2:saurabh-patch-11 - Merged commits: 1. 0757a81
[chaika] bugfixes
- merged latest code from mainline branch
[MPI] Bug Fixes
- merged latest code from mainline branch
…8-make-tests-namespace-agnostic
Accepted Public Pull Requests: - magento#15891: Remove parameter from method calling (by @saurabh-aureate) - magento#15892: Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D� (by @namratachangani) - magento#15888: Correct typo correction js files (by @saurabh-aureate) - magento#13862: Add compare list link to success message after adding a product (by @avstudnitz)
…8-make-tests-namespace-agnostic
MAGETWO-86125: Sorting on price of configurable products in catalog not working properly
…8-make-tests-namespace-agnostic
…tests-namespace-agnostic [borg] MAGETWO-92468: Make PR testsuite namespace-agnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15986
Description
Out of the box,
\Magento\Captcha\Observer\CaptchaStringResolverclass is not covered by unit tests. This PR adds unit tests coverage for the mentioned class.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A