Skip to content

refac(ci): improve build time #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2019
Merged

refac(ci): improve build time #123

merged 2 commits into from
Jan 7, 2019

Conversation

juancarlostong
Copy link
Contributor

Summary

Optimizations to the 'Integration tests' triggering build:

  • added merge_mode: replace, trigger job only needs to run shell script, so just do that and nothing else.
  • added cache: false, caching is used for some *-sdk, this disables it for the 'Integration tests' triggering build since it is not needed.
  • replaced after_success: skip with after_success: travis_terminate 0, this avoids running srcclr which saves 18-30s from build time.

@juancarlostong juancarlostong force-pushed the jctong/improve_build_time branch from 8b0b1e9 to c3c7cfa Compare January 2, 2019 20:01
@juancarlostong juancarlostong force-pushed the jctong/improve_build_time branch from 54f09d4 to 746c97f Compare January 2, 2019 20:37
@juancarlostong juancarlostong removed the bug label Jan 2, 2019
@juancarlostong juancarlostong force-pushed the jctong/improve_build_time branch 3 times, most recently from 3f425d3 to dd77266 Compare January 2, 2019 21:34
@juancarlostong
refac(ci): improve build time
0c03bde 
also added testing of mono: 5.18.0 in order to force travis to run
unit tests
@juancarlostong juancarlostong force-pushed the jctong/improve_build_time branch from dd77266 to 0c03bde Compare January 2, 2019 22:33
msohailhussain
msohailhussain approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancarlostong juancarlostong mentioned this pull request Dec 13, 2018
Closed
mikeproeng37
mikeproeng37 approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 8750a9a into master Jan 7, 2019
@juancarlostong juancarlostong mentioned this pull request Jan 17, 2019
Merged
@msohailhussain msohailhussain mentioned this pull request Jan 23, 2019
Closed
@juancarlostong juancarlostong mentioned this pull request Jan 24, 2019
Closed
@msohailhussain msohailhussain mentioned this pull request Jan 26, 2019
Merged
@juancarlostong juancarlostong mentioned this pull request Feb 28, 2019
Merged
@msohailhussain msohailhussain mentioned this pull request Mar 1, 2019
Closed
@optibot optibot mentioned this pull request Mar 6, 2019
Closed
@juancarlostong juancarlostong mentioned this pull request Mar 27, 2019
Merged
@juancarlostong juancarlostong deleted the jctong/improve_build_time branch April 1, 2019 18:32
@msohailhussain msohailhussain mentioned this pull request Apr 11, 2019
Merged
This was referenced May 29, 2019
Merged
Merged
@msohailhussain msohailhussain mentioned this pull request Sep 6, 2019
Closed
@msohailhussain msohailhussain mentioned this pull request Nov 15, 2019
Closed
@juancarlostong juancarlostong mentioned this pull request Feb 7, 2020
Merged
@fscelliott fscelliott mentioned this pull request May 5, 2020
Merged
@juancarlostong juancarlostong mentioned this pull request May 27, 2020
Merged
This was referenced Jun 30, 2020
Merged
Closed
This was referenced Jul 7, 2020
Merged
Merged
@msohailhussain msohailhussain mentioned this pull request Jul 28, 2020
Merged
@mfahadahmed mfahadahmed mentioned this pull request Dec 20, 2018
Open
@msohailhussain msohailhussain mentioned this pull request Nov 9, 2020
Merged
@mnoman09 mnoman09 mentioned this pull request Jun 30, 2021
Merged
@msohailhussain msohailhussain mentioned this pull request Jul 8, 2021
Merged
@msohailhussain msohailhussain mentioned this pull request Jul 17, 2021
Merged
This was referenced Aug 11, 2021
Closed
Closed
This was referenced Sep 7, 2021
Closed
Closed
@msohailhussain msohailhussain mentioned this pull request Dec 21, 2021
Merged
@msohailhussain msohailhussain mentioned this pull request Feb 14, 2022
Closed
This was referenced Mar 14, 2022
Closed
Closed
@mnoman09 mnoman09 mentioned this pull request Apr 5, 2022
Merged
@mnoman09 mnoman09 mentioned this pull request May 23, 2022
Merged
@ozayr-zaviar ozayr-zaviar mentioned this pull request Jun 28, 2022
Merged
@mnoman09 mnoman09 mentioned this pull request Jul 27, 2022
Merged
@mnoman09 mnoman09 mentioned this pull request Feb 8, 2023
Merged
@mnoman09 mnoman09 mentioned this pull request Feb 21, 2023
Merged
@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlostong @mikeproeng37 @msohailhussain