-
Notifications
You must be signed in to change notification settings - Fork 25
refactor!: migration logging system #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
45c0a95 to
4a5b659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR represents the first step in refactoring the migration logging system. The changes focus on standardizing log entry creation and data collection while maintaining backward compatibility.
- Introduces a new
SwagMigrationLogBuilderfor consistent log entry creation across the system - Refactors
MigrationContextconstructor to improve parameter order and makeconnectiona required parameter - Simplifies fixture files by removing redundant source ID tracking and verbose log parameters
- Updates test files to use the modernized logging system and parameter structures
Reviewed Changes
Copilot reviewed 240 out of 244 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Various test snapshots | Updated to reflect simplified log structure without source ID tracking |
| Test files across Profile/ | Updated MigrationContext constructor calls with reordered parameters |
| Converter test files | Simplified assertion patterns for log codes without parameter validation |
| Gateway and media processing | Updated to use new logging builder pattern and simplified connection handling |
| Logging classes | Refactored to extend AbstractSwagMigrationLogEntry with simplified structure |
Comments suppressed due to low confidence (1)
tests/Profile/Shopware55/Converter/TranslationConverterTest.php:1
- This assertion is duplicated on line 437. The second assertion should likely check
$logs[3]['code']instead of$logs[2]['code']again, or verify a different aspect of the log entry.
<?php declare(strict_types=1);
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - src/Resources/app/administration/** | ||
| - tests/Jest/** | ||
| - .github/workflows/admin.yml | ||
| workflow_call: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo before merge: check all commit message for conventional commit and don't squash merge
Co-authored-by: Lars Kemper <[email protected]>
Co-authored-by: Lars Kemper <[email protected]>
resolves #11808