Skip to content

Conversation

@larskemper
Copy link
Member

@larskemper larskemper commented Aug 19, 2025

resolves #11808

@larskemper larskemper force-pushed the feature/migration-logging-refactor branch from 45c0a95 to 4a5b659 Compare August 28, 2025 08:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR represents the first step in refactoring the migration logging system. The changes focus on standardizing log entry creation and data collection while maintaining backward compatibility.

  • Introduces a new SwagMigrationLogBuilder for consistent log entry creation across the system
  • Refactors MigrationContext constructor to improve parameter order and make connection a required parameter
  • Simplifies fixture files by removing redundant source ID tracking and verbose log parameters
  • Updates test files to use the modernized logging system and parameter structures

Reviewed Changes

Copilot reviewed 240 out of 244 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Various test snapshots Updated to reflect simplified log structure without source ID tracking
Test files across Profile/ Updated MigrationContext constructor calls with reordered parameters
Converter test files Simplified assertion patterns for log codes without parameter validation
Gateway and media processing Updated to use new logging builder pattern and simplified connection handling
Logging classes Refactored to extend AbstractSwagMigrationLogEntry with simplified structure
Comments suppressed due to low confidence (1)

tests/Profile/Shopware55/Converter/TranslationConverterTest.php:1

  • This assertion is duplicated on line 437. The second assertion should likely check $logs[3]['code'] instead of $logs[2]['code'] again, or verify a different aspect of the log entry.
<?php declare(strict_types=1);

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larskemper larskemper changed the title refactor!: migration logging system (step 1) refactor!: migration logging system Sep 1, 2025
@larskemper larskemper requested review from yusufttur and removed request for GitEvil November 6, 2025 13:35
- src/Resources/app/administration/**
- tests/Jest/**
- .github/workflows/admin.yml
workflow_call:
Copy link
Member Author

@larskemper larskemper Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo before merge: check all commit message for conventional commit and don't squash merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Step 1: Refactor logging system to include all data we need for the user (UI) and developer facing (log file) presentations

7 participants