fix github migration error when using multiple tokens (#34144) #34302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git authorization was not taking into account multiple token feature, leading to auth failures Closes: go-gitea#34141 --------- Co-authored-by: wxiaoguang <[email protected]>
GiteaBot
added
lgtm/need 2
hiifong
approved these changes
Apr 28, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 28, 2025
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #34144 by @TheFox0x7
Git authorization was not taking into account multiple token feature, leading to auth failures
Closes: #34141
I made it default to first token. I'm honestly not sure if it wouldn't be better to scrap the multi token feature instead. The UI hides the tokens so it's hard to tell if no mistake was made in the input and it's the only provider "supporting" this.
I guess the intention was to somewhat speed up migration from github for a single repository which is nice too.